fix: revert the nodejs-24-minimal bump that broke the hermetic build - #5390
Open
gustavolira wants to merge 2 commits into
Open
fix: revert the nodejs-24-minimal bump that broke the hermetic build#5390gustavolira wants to merge 2 commits into
gustavolira wants to merge 2 commits into
Conversation
main has been red since fbd9a52. The hermetic build fails on both arches at the skeleton stage: Problem: conflicting requests - nothing provides xz-libs(x86-64) = 1:5.6.2-4.el10_2.1 needed by xz-1:5.6.2-4.el10_2.1.x86_64 redhat-developer#5384 bumped only the runner image, nodejs-24-minimal, from 10.2-1788245909 to 10.2-1789045317. The skeleton stays on nodejs-24:10.2-1788939823, and that is not an oversight: nodejs-24 has no newer tag, so the two images cannot be aligned right now. rpm-lockfile-prototype resolves against the Containerfile and drops whatever the base images already ship. Regenerated against the newer minimal image (redhat-developer#5389) it dropped xz-libs entirely — 4 occurrences before, 0 after — while keeping xz. The failing dnf install runs in the skeleton stage, on the older image, where that xz-libs is not present. Reverting both files together restores d1dbd50's combination, which built green at 17:55. Bumping the minimal image again should wait until nodejs-24 gets a matching build, so the lockfile can be resolved against a consistent pair. Neither PR built this combination before it landed: redhat-developer#5384 carried [skip-build], and redhat-developer#5389's own "Build Image (Hermetic)" step reports skipped, so its green check never compiled anything. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
kim-tsao
approved these changes
Sep 11, 2026
Member
|
/retest |
|
@gustavolira: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been red sincefbd9a52b. The hermetic build fails on both arches, at the skeleton stage:What happened
#5384 bumped only the runner image:
That is not an oversight to fix by bumping the skeleton too:
ubi10/nodejs-24has no tag newer than10.2-1788939823. The two images publish on different cadences and cannot be aligned today.rpm-lockfile-prototyperesolves against the Containerfile and omits whatever the base images already ship. Regenerated against the newer minimal image (#5389), it droppedxz-libsfrom the prefetch entirely while keepingxz:rpms.lock.yamlxzxz-libs5.6.2-4.el10_2.15.6.2-4.el10_2.1(4 occurrences)5.6.2-4.el10_2.1The failing
dnf installruns in the skeleton stage, on the older image, which does not carry thatxz-libs. In a hermetic build the prefetch is alldnfcan see, so it cannot resolve.Why revert rather than patch forward
Reverting both files restores
d1dbd50d's combination, which built green at 17:55 today. Re-bumping the minimal image should wait fornodejs-24to get a matching build, so the lockfile can be resolved against a consistent pair rather than a mismatched one.How it got in
Neither PR built this combination:
[skip-build]in its title.Build Image (Hermetic)step reportsskipped—Check Image and Relevant Changesdecided there was nothing relevant, so its green check never compiled anything.Worth a follow-up: a change to
build/containerfiles/Containerfileorrpms.lock.yamlis exactly the change that should never skip the image build.🤖 Generated with Claude Code