Skip to content

[Parallel] Fix --debug not working in parallel - #2307

Merged
samsonasik merged 4 commits into
mainfrom
fix-debug-not-working-in-parallel
May 13, 2022
Merged

[Parallel] Fix --debug not working in parallel#2307
samsonasik merged 4 commits into
mainfrom
fix-debug-not-working-in-parallel

Conversation

@samsonasik

@samsonasik samsonasik commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Before

bin/rector process src/Config/  --clear-cache --debug

                                                                                                                        
 [OK] Rector is done!

After

bin/rector process src/Config/  --clear-cache --debug

src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\DeadCode\Rector\Node\RemoveNonExistingVarAnnotationRector

[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector

[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\DeadCode\Rector\Node\RemoveNonExistingVarAnnotationRector

[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector

ref rectorphp/rector#7164 (reply in thread)

@samsonasik
samsonasik force-pushed the fix-debug-not-working-in-parallel branch from c06fbe9 to cbec756 Compare May 13, 2022 10:18
@samsonasik

samsonasik commented May 13, 2022

Copy link
Copy Markdown
Member Author

It seems make test error:



There were 2 errors:

1) Rector\Tests\Parallel\Command\WorkerCommandLineFactoryTest::test with data set #0 (array('process', array('src')), ''/usr/bin/php8.1' 'main_scrip...o-ansi')
Symfony\Component\Console\Exception\InvalidArgumentException: The "debug" option does not exist.

while registering to AbstractProcessCommand make it not displayed.

@samsonasik
samsonasik marked this pull request as draft May 13, 2022 10:47
@samsonasik
samsonasik marked this pull request as ready for review May 13, 2022 11:48
@samsonasik

samsonasik commented May 13, 2022

Copy link
Copy Markdown
Member Author

Fixed 🎉

@samsonasik

samsonasik commented May 13, 2022

Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik

samsonasik commented May 13, 2022

Copy link
Copy Markdown
Member Author

I am merging it ;)

@samsonasik
samsonasik merged commit 26d2589 into main May 13, 2022
@samsonasik
samsonasik deleted the fix-debug-not-working-in-parallel branch May 13, 2022 16:10
@TomasVotruba

TomasVotruba commented May 13, 2022

Copy link
Copy Markdown
Member

👍

@samsonasik samsonasik mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba @actions-user