Skip to content

Commit 2f1c4bc

Browse files
TomasVotrubaTomasVotruba
authored
[Set] Extract mock-to-stub rules into dedicated PHPUNIT_MOCK_TO_STUB set (#688)
1 parent 2e1cd29 commit 2f1c4bc

3 files changed

Lines changed: 24 additions & 10 deletions

File tree

‎config/sets/phpunit-mock-to-stub.php‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
use Rector\Config\RectorConfig;
6+
use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubInCoalesceArgRector;
7+
use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector;
8+
use Rector\PHPUnit\PHPUnit120\Rector\Class_\PropertyCreateMockToCreateStubRector;
9+
use Rector\PHPUnit\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector;
10+
11+
return static function (RectorConfig $rectorConfig): void {
12+
$rectorConfig->rules([
13+
// stubs over mocks
14+
CreateStubOverCreateMockArgRector::class,
15+
CreateStubInCoalesceArgRector::class,
16+
ExpressionCreateMockToCreateStubRector::class,
17+
PropertyCreateMockToCreateStubRector::class,
18+
]);
19+
};

‎config/sets/phpunit120.php‎

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,15 @@
33
declare(strict_types=1);
44

55
use Rector\Config\RectorConfig;
6-
use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubInCoalesceArgRector;
7-
use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector;
86
use Rector\PHPUnit\PHPUnit120\Rector\Class_\AssertIsTypeMethodCallRector;
9-
use Rector\PHPUnit\PHPUnit120\Rector\Class_\PropertyCreateMockToCreateStubRector;
107
use Rector\PHPUnit\PHPUnit120\Rector\Class_\RemoveOverrideFinalConstructTestCaseRector;
11-
use Rector\PHPUnit\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector;
8+
use Rector\PHPUnit\Set\PHPUnitSetList;
129

1310
return static function (RectorConfig $rectorConfig): void {
11+
$rectorConfig->sets([PHPUnitSetList::PHPUNIT_MOCK_TO_STUB]);
12+
1413
$rectorConfig->rules([
1514
RemoveOverrideFinalConstructTestCaseRector::class,
1615
AssertIsTypeMethodCallRector::class,
17-
18-
// stubs over mocks
19-
CreateStubOverCreateMockArgRector::class,
20-
CreateStubInCoalesceArgRector::class,
21-
ExpressionCreateMockToCreateStubRector::class,
22-
PropertyCreateMockToCreateStubRector::class,
2316
]);
2417
};

‎src/Set/PHPUnitSetList.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ final class PHPUnitSetList
2727

2828
public const string PHPUNIT_120 = __DIR__ . '/../../config/sets/phpunit120.php';
2929

30+
public const string PHPUNIT_MOCK_TO_STUB = __DIR__ . '/../../config/sets/phpunit-mock-to-stub.php';
31+
3032
public const string PHPUNIT_CODE_QUALITY = __DIR__ . '/../../config/sets/phpunit-code-quality.php';
3133

3234
public const string ANNOTATIONS_TO_ATTRIBUTES = __DIR__ . '/../../config/sets/annotations-to-attributes.php';

0 commit comments

Comments
 (0)