Conversation
Luna712
left a comment
There was a problem hiding this comment.
This fixes all the issues I previously mentioned, but I also noticed another issue with this (though preexisting maybe even on stable) if you select something the multi delete button bytes don't update when total bytes for a certain item change, until you leave the downloads fragment and return to it. I can look into that one though later if you want.
This has always been the case as the actual byte count on each item is rerendered by hooking private state, that is to say the downloadviewmodel does not recalculate byte count at all. This is also not a bug/feature this pull request seeks out to fix. Moreover, I also do not want anyone to touch that before the download pr #2037 is done, as that modifies that part of the business logic quite a bit. |
After some discussion with @Luna712 I decided to fix some minor issues with the old code.
Yall are free to test it out, but I will probs merge it soon.