Skip to content

Fixed all H2 headings#943

Merged
mpoulin merged 1 commit into
masterfrom
fix-h2-headers
Dec 5, 2018
Merged

Fixed all H2 headings#943
mpoulin merged 1 commit into
masterfrom
fix-h2-headers

Conversation

@mpoulin

@mpoulin mpoulin commented Dec 4, 2018

Copy link
Copy Markdown
Contributor

Before, H2 formatting was not consistent.
Now, all H2 headings use over/under asterisks.

Before, H2 fomratting was not consistent.
Now, all H2 headings use over/under asterisks.
@dbader

dbader commented Dec 4, 2018

Copy link
Copy Markdown
Member

@mpoulin Thanks so much Marc, this is great! Hurray for consistency 😄

@return42

return42 commented Dec 5, 2018

Copy link
Copy Markdown

Sorry for nitpicking; If we change so many headings why not all and using recommended style for sections and subsections

@mpoulin

mpoulin commented Dec 5, 2018

Copy link
Copy Markdown
Contributor Author

@return42 Thanks for your comment.
Yes, the goal is to change all the headings to the recommended Sphinx style.

A prior commit fixed the H1 headings:
693c8ca

This commit fixes the H2 headings and the next commit will fix the H3 headings.
Since these are global changes and touch so many files, I thought it best to make the changes in phases.

@return42

return42 commented Dec 5, 2018

Copy link
Copy Markdown

@mpoulin thanks for clarifying .

@mpoulin mpoulin merged commit cafe323 into master Dec 5, 2018
@mpoulin mpoulin deleted the fix-h2-headers branch December 5, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants