Skip to content

[search] removing extra bottom line#935

Merged
dbader merged 3 commits into
realpython:masterfrom
s-pace:www/fix/search_script_position
Nov 7, 2018
Merged

[search] removing extra bottom line#935
dbader merged 3 commits into
realpython:masterfrom
s-pace:www/fix/search_script_position

Conversation

@s-pace

@s-pace s-pace commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

Enhance #934

@dbader

dbader commented Nov 7, 2018

Copy link
Copy Markdown
Member

@s-pace Cool—can you change the placeholder on the search input to "Search the Guide"? Thx

#934 (comment)

@s-pace

s-pace commented Nov 7, 2018

Copy link
Copy Markdown
Contributor Author

Sure!

@dbader

dbader commented Nov 7, 2018

Copy link
Copy Markdown
Member

Perfect, thanks @s-pace :-) LGTM!

@dbader dbader merged commit 4a4dae7 into realpython:master Nov 7, 2018
@s-pace

s-pace commented Nov 8, 2018

Copy link
Copy Markdown
Contributor Author

Feel free to provide us any feedback. We would love to enhance our tool

@dbader

dbader commented Nov 8, 2018

Copy link
Copy Markdown
Member

@s-pace Cheers I'll keep it in mind! Love how quick the search is!

@s-pace s-pace deleted the www/fix/search_script_position branch April 17, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants