Adds context manager section to structure.rst#627
Merged
Conversation
Contributor
There was a problem hiding this comment.
Would you mind adding "at runtime" after "to an action"/
Contributor
There was a problem hiding this comment.
It's not necessarily running functions (as you show with the second example you provided).
Contributor
|
Hey @sirMackk ! Thanks for putting this together. It's a really great start. I have some changes I'd love for you to make and a question in there about one of your examples. Ping me here when you've made changes you'd like me to review. Cheers, |
kennethreitz
added a commit
that referenced
this pull request
Jan 15, 2016
Adds context manager section to structure.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that there was no mention of context managers in the guide. Personally I've found them to be a way underrated mechanism to manage complexity even in small projects.