Skip to content

virtualenv duplicate fix#572

Merged
sigmavirus24 merged 1 commit into
realpython:masterfrom
varunagrawal:env
Oct 11, 2015
Merged

virtualenv duplicate fix#572
sigmavirus24 merged 1 commit into
realpython:masterfrom
varunagrawal:env

Conversation

@varunagrawal

Copy link
Copy Markdown
Contributor

Edited env.rst to remove duplication of virtualenv section and provide better flow to the actual virtualenv section.
Fix for #123

@varunagrawal varunagrawal changed the title updated virtualenv sectio to remove duplicates virtualenv duplicate fix Oct 2, 2015
@sigmavirus24

Copy link
Copy Markdown
Contributor

I'm not sure this is what that bug was suggesting happen. I think we wanted links to the virtualenv section with a very short mention of it here. There's still duplication.

@varunagrawal

Copy link
Copy Markdown
Contributor Author

I did put a short description with just enough content to give a high level overview and generate interest for anyone looking into virtualenv. Any recommendations for what should be changed?

@varunagrawal

Copy link
Copy Markdown
Contributor Author

Any updates on this?

@sigmavirus24

Copy link
Copy Markdown
Contributor

On a second review this looks good. Thanks @varunagrawal

sigmavirus24 added a commit that referenced this pull request Oct 11, 2015
@sigmavirus24 sigmavirus24 merged commit 3c03e24 into realpython:master Oct 11, 2015
@varunagrawal varunagrawal deleted the env branch October 11, 2015 18:04
@varunagrawal varunagrawal restored the env branch October 11, 2015 18:04
@varunagrawal varunagrawal deleted the env branch October 11, 2015 18:04
@varunagrawal varunagrawal restored the env branch October 11, 2015 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants