Skip to content

Conversation

@stsewd
Copy link
Member

@stsewd stsewd commented Aug 28, 2025

Extracted from #12276

@read-the-docs-community
Copy link

read-the-docs-community bot commented Aug 28, 2025

Documentation build overview

📚 docs | 🛠️ Build #29410740 | 📁 Comparing 57d2e52 against latest (2d91beb)


🔍 Preview build

Show files changed (5 files in total): 📝 5 modified | ➕ 0 added | ➖ 0 deleted
File Status
build-customization.html 📝 modified
support.html 📝 modified
visual-diff.html 📝 modified
about/index.html 📝 modified
tutorial/index.html 📝 modified

@stsewd stsewd marked this pull request as ready for review August 28, 2025 20:22
@stsewd stsewd requested a review from a team as a code owner August 28, 2025 20:22
@stsewd stsewd requested a review from agjohnson August 28, 2025 20:22
@stsewd stsewd requested a review from ericholscher August 28, 2025 20:22
@stsewd stsewd moved this to Needs review in 📍Roadmap Aug 28, 2025
Copy link

@alpoz11 alpoz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And wat you have too

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, just a few notes.

Visual diff shows all the sections that have changed, highlighting their differences with red/green background colors.
You can jump between each of these chunks by clinking on the up/down arrows.

Show build overview in pull requests
Copy link
Member

@ericholscher ericholscher Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely try to promote this more in marketing, because I think it's a great viral feature for non-users to learn about the value of RTD.

I wonder if we should default it on? Or have a prompt for users to turn it on or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we could have a blog post too


Visual diff will show all the sections that have changed and their differences highlighted with red/green background colors.
Then you can jump between each of these chunks by clinking on the up/down arrows.
Ignored files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot we implemented this! Super useful, and I will go change this on a few projects :)


Configuring Visual Diff
-----------------------
You can configure a list of files or patterns to be ignored when listing the files that changed in the pull request.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can configure a list of files or patterns to be ignored when listing the files that changed in the pull request.
You can configure a list of files or patterns to be ignored when listing the files that changed in the pull request.
This is useful when you have files that have a date in them, or listing/archive files that show changes without content changes in those files.

~~~~~~~~~~~~

The base version is the version of the documentation that is used to compare against the pull request.
By default, this is the latest version of the documentation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, this is the latest version of the documentation.
By default, this is the ``latest`` version of the documentation.

What is the primary reason users would want this? If they didn't have a latest version enabled? We should mention a use case here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case their main branch isn't pointed to latest.

Comment on lines +86 to +87
- The diff is done between the files from the latest successful build of the pull request and the default base version (latest by default).
If your pull request gets out of sync with its base branch, the diff may not be accurate, and may show unrelated files and sections as changed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really love to find a better way to handle this, as it's the #1 UX issue with it that I see regularly. Not sure how to really fix it tho, perhaps using git to see what files have changed between the base main 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened an issue about this some time ago #12232

@read-the-docs-community
Copy link

Documentation build overview

📚 dev | 🛠️ Build #29410739 | 📁 Comparing 57d2e52 against latest (2d91beb)


🔍 Preview build

Show files changed (6 files in total): 📝 6 modified | ➕ 0 added | ➖ 0 deleted
File Status
contribute.html 📝 modified
install.html 📝 modified
search-integration.html 📝 modified
style-guide.html 📝 modified
design/embed-api.html 📝 modified
design/theme-context.html 📝 modified

@stsewd stsewd merged commit e1cf9ba into main Sep 2, 2025
3 of 4 checks passed
@stsewd stsewd deleted the update-docs-diff branch September 2, 2025 17:23
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants