Build: complete cleanup #12430
Merged
Build: complete cleanup #12430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clean_build` is not called when the task is terminated and there could be some lingering files around. Instead of only deleting the files for the current build, we delete the whole `settings.DOCROOT` path when the build starts.
|
I think this is a reasonable thing to be able to ship -- I think we should put it behind a feature flag so we can deploy it this week and then enabling/disabling it per project to start testing. |
|
I added a feature flag for this 👍🏼 -- We should be able to deploy it today if we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean_buildis not called when the task is terminated and there could be some lingering files around. Instead of only deleting the files for the current build, we delete the wholesettings.DOCROOTpath when the build starts.