Skip to content

Fix Docker memory limits #12396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2025
Merged

Fix Docker memory limits #12396

merged 3 commits into from
Aug 13, 2025

Conversation

@humitos
Copy link
Member

@humitos humitos commented Aug 12, 2025

No description provided.

@humitos humitos requested a review from a team as a code owner August 12, 2025 16:43
@humitos humitos requested a review from agjohnson August 12, 2025 16:43
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Aug 12, 2025
stsewd
stsewd reviewed Aug 12, 2025
View reviewed changes
stsewd
stsewd reviewed Aug 12, 2025
View reviewed changes
@humitos @stsewd
Update readthedocs/settings/base.py
e6e0d45 
Co-authored-by: Santos Gallegos <stsewd@proton.me>
stsewd
stsewd reviewed Aug 12, 2025
View reviewed changes
readthedocs/settings/base.py Outdated
else:
memory_limit = default_memory_limit

if memory_limit:
Copy link
Member

@stsewd stsewd Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block needs to be removed now that the other suggestion was applied

@humitos humitos requested a review from stsewd August 12, 2025 18:23
stsewd
stsewd approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to reverse the commit that was hotfixed, so this change applies cleanly on next deploy

@humitos humitos merged commit c48fcaf into main Aug 13, 2025
3 checks passed
@humitos humitos deleted the humitos/memory-limits branch August 13, 2025 11:11
@ericholscher
Copy link
Member

ericholscher commented Aug 14, 2025 •
edited
Loading

I reverted c92a3b6182340e4c92f7dbd4c352ee9ba3d76547 and applied the merged commit to rel/relcorp 👍

ericholscher pushed a commit that referenced this pull request Aug 14, 2025
@humitos @stsewd @ericholscher
Fix Docker memory limits (#12396)
9c7b03a 
Co-authored-by: Santos Gallegos <stsewd@proton.me>
ericholscher pushed a commit that referenced this pull request Aug 14, 2025
@humitos @stsewd @ericholscher
Fix Docker memory limits (#12396)
87eee6c 
Co-authored-by: Santos Gallegos <stsewd@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericholscher ericholscher ericholscher approved these changes

@stsewd stsewd stsewd approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/backend

Assignees

@humitos humitos

Labels

PR: hotfix Pull request applied as hotfix to release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@humitos @ericholscher @stsewd