Dashboard: optimize projects queryset #12383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Aug 7, 2025
| Build.internal.filter(project=OuterRef("project_id")) | ||
| .order_by("-date") | ||
| .values_list("id", flat=True)[:1] | ||
| Build.internal.filter(project=OuterRef("project_id")).order_by("-date").values("pk")[:1] |
There was a problem hiding this comment.
Did this make it faster, or just cleaner?
There was a problem hiding this comment.
Just cleaner, looks like django was able to get to the same SQL
stsewd
added a commit
that referenced
this pull request
Aug 11, 2025
…12385) This is on top of #12383 as another PR in case we see a regression in performance, it would be easier to just revert this change. Instead of pre-fetching, we annotate, so we can use exist instead of fetching the query. This allows to just make one query. But this does add some extra complexity to the query itself, which is less overhead than doing a prefetch over the queryset itself, but the pagination package we are using calls .count(), and django includes the annotation by default... which makes that query slower as well... but testing in production shows faster results still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be 35 queries. I found another optimization to make it to constant time, but will open another PR as it may produce a slow query..