-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Comparing changes
Open a pull request
base repository: readthedocs/readthedocs.org
base: 15.2.1
head repository: readthedocs/readthedocs.org
compare: 15.2.2
- 13 commits
- 31 files changed
- 3 contributors
Commits on Sep 2, 2025
-
Configuration menu - View commit details
-
Copy full SHA for e1cf9ba - Browse repository at this point
Copy the full SHA e1cf9baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 077abcf - Browse repository at this point
Copy the full SHA 077abcfView commit details -
Git services: allow updating a single repository (#12429)
When syncing permissions for SSO, we don't need to sync all repositories the user has access to, we just need to update the permissions of the repositories that are connected to projects that belong to SSO organizations. So this adds a way to just update one single repository at a time for all providers. We don't need to do this for GH app projects, since they are kept up to date via a webhook. Since this task should be faster now, we could run it more frequently, so permissions are reflected faster on RTD.
Configuration menu - View commit details
-
Copy full SHA for a8a29fe - Browse repository at this point
Copy the full SHA a8a29feView commit details
Commits on Sep 4, 2025
-
Projects: improve deletion (#12456)
For some related fields, Django first does a select, then it probably loads each object into memory? But after that it does the deletion using a `IN` statement with the ID of the objects... Using raw_delete avoids that, but it can also cause integrity problems, as Django does its own implementation of on_delete, so I chose models that don't have additional relations and also shouldn't have problems as they are always deleted when the project is deleted. Another source of problems is when models have foreign fields with on_delete=SET_NULL, as django will do an UPDATE over the model with all the related fields... for example for latest_build, django will run an update over all projects with an `IN (... all builds IDs..)`, to set the latest_build ID to null..., which is silly since the whole project model is being deleted, but django doesn't know that lates_build can only contain a build from the project. A raw delete could help, but builds and versions have a lot of related fields in other models, so I'm a little hesitant. Closes #12410 Ref #10040
Configuration menu - View commit details
-
Copy full SHA for c7a8e2d - Browse repository at this point
Copy the full SHA c7a8e2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6ad62 - Browse repository at this point
Copy the full SHA ed6ad62View commit details -
Project: use get_original_latest_version in form (#12460)
This is the same logic we have in https://github.com/readthedocs/readthedocs.org/blob/a8a29fe29292027a4e2a44cc468cea4adc70e390/readthedocs/projects/models.py#L1164-L1181 and it already excludes latest I'm doing small refactors to rely less on get_default_branch, as that contains some extra logic that we already run to have latest always in sync.
Configuration menu - View commit details
-
Copy full SHA for c7c96de - Browse repository at this point
Copy the full SHA c7c96deView commit details -
Project: use latest version for syncing versions (#12461)
We should refactor this task so it doesn't require a version, but that's a bigger change... This is basically the same as it was before, as LATEST is the only version that its identifier is the same as the default branch. I'm doing small refactors to rely less on get_default_branch, as that contains some extra logic that we already run to have latest always in sync.
Configuration menu - View commit details
-
Copy full SHA for f959b2a - Browse repository at this point
Copy the full SHA f959b2aView commit details -
OAuth: re-enable sync active user repos task (#12443)
- Take into consideration active users from the last 30 days only. - Ignore GitHub App, so we don't re-sync installations over and over again, as users can share the same installation, and repos from the GH app are kept in sync via a webhook. This task now completes in 42 minutes. Closes #12406
Configuration menu - View commit details
-
Copy full SHA for 9ffd0c7 - Browse repository at this point
Copy the full SHA 9ffd0c7View commit details -
Version: use git_identifier in vcs_url (#12459)
- This was duplicating the logic from git_identifier - Our `latest` version already has the name of the branch/tag in the identifier, no need to use `get_default_branch` - We no longer create branches or tags with the origin prefix. I'm doing small refactors to rely less on get_default_branch, as that contains some extra logic that we already run to have `latest` always in sync.
Configuration menu - View commit details
-
Copy full SHA for 5277376 - Browse repository at this point
Copy the full SHA 5277376View commit details -
Versions: more tests for sync versions (#12458)
Extracted from #10927, trying to get a smaller diff on that PR :)
Configuration menu - View commit details
-
Copy full SHA for 2992fb6 - Browse repository at this point
Copy the full SHA 2992fb6View commit details
Commits on Sep 8, 2025
-
docs: fix git-lfs changelog overrides the local one (#12464)
There are no reason to extract the entire archive when we only need `git-lfs` binary. The archive also contains a `CHANGELOG.md` file, which can override the local one.
Configuration menu - View commit details
-
Copy full SHA for 7c84dd1 - Browse repository at this point
Copy the full SHA 7c84dd1View commit details
Commits on Sep 9, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 75a837a - Browse repository at this point
Copy the full SHA 75a837aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a01bb5e - Browse repository at this point
Copy the full SHA a01bb5eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 15.2.1...15.2.2