-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Comparing changes
Open a pull request
base repository: readthedocs/readthedocs.org
base: 15.1.0
head repository: readthedocs/readthedocs.org
compare: 15.2.0
- 12 commits
- 25 files changed
- 4 contributors
Commits on Aug 20, 2025
-
Builds: don't check for FF flag (#12422)
We are going to enable this for all the projects with the FF by default now, which means that there isn't going to be a relationship between `Project` and `Feature` once it's deployed.
Configuration menu - View commit details
-
Copy full SHA for 2134030 - Browse repository at this point
Copy the full SHA 2134030View commit details
Commits on Aug 21, 2025
-
Build: use a longer and more accurate expiricy time for API key (#12425)
This formula considers builds that are retried multiple times.
Configuration menu - View commit details
-
Copy full SHA for 36ee040 - Browse repository at this point
Copy the full SHA 36ee040View commit details -
Builds: healthcheck permissions (#12423)
We want to skip the default permsissions check here (done at `get_queryset()` method) because it filters the object by build API key and/or user access. Since we are making an anonymous request without a build API key, we need to skip this check and base it only on the `?builder=` GET attribute.
Configuration menu - View commit details
-
Copy full SHA for 8a089a3 - Browse repository at this point
Copy the full SHA 8a089a3View commit details
Commits on Aug 25, 2025
-
Git services: improve sync repos (#12428)
Common changes across providers: - A new method to just update a remote repository from the data returned by the API was added, this is in order to make it easy to re-use this method when support for updating a single repo is added (will do this in another PR on top of this one). - We were iterating over repositories twice for GitHub and BB, once by listing all the repositories the user has access to, and then again by iterating over all the repositories from the organizations the user has access to, this was also incorrectly adding a relationship between the user and repositories the use didn't actually have access, as that endpoint will return all public repositories, even if the user doesn't belong to it. - sync_organizations now basically just creates the user-organization relation only. - Since several repositories can belong to the same organization, we don't really need to update the same organization over and over again, just once, so a cache was introduced for it. This is also a reason why the creation of the user-organization relationship was moved outside `create_organization`. Specific changes: - For Bitbucket, we weren't updating a repository if the workspace it belongs was changed, we now update those. This is the same problem we had with Gitlab #12233. - For Bitbucket, we were creating the repo-user relationship and then updating that relationship for the repositories where the user is an admin. This wasn't resetting the admin status to false for repos the user no longer had that permission, we now always default to admin=False, and then we update the repositories where the user is admin in the other call. - In Bitbucket, we don't have organizations, we have projects and workspaces, we are using workspaces as our organizations. But in BB, every repository is linked to a workspace (a user can be a workspace), so we always create an organization for each repository. - Since all other providers are fetching all repositories in the `sync_repositories` method, I changed Gitlab do also do that. In order to do that I reverted to use the previous /projects endpoint (#12233). - GitLab sometimes returns avatars with a relative URL `/~/uploads...` instead of including the domain as well, so we are normalizing all URLs from Gitlab now. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for cc69f23 - Browse repository at this point
Copy the full SHA cc69f23View commit details -
Builds: improve DB query for unhealthy builds (#12431)
Filter by `date` to use one of the fast DB indexes we have in the `Build` model. Solves https://read-the-docs.sentry.io/issues/6806637157/
Configuration menu - View commit details
-
Copy full SHA for 43ad56f - Browse repository at this point
Copy the full SHA 43ad56fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6474393 - Browse repository at this point
Copy the full SHA 6474393View commit details -
Dependencies: upgrade them all (#12437)
Attempt to fix the auto-upgrade from #12434
Configuration menu - View commit details
-
Copy full SHA for 7fdf310 - Browse repository at this point
Copy the full SHA 7fdf310View commit details -
Tests: fix tests con .com (#12439)
This setting is overridden in .com, so this tests fails
Configuration menu - View commit details
-
Copy full SHA for 8121bb7 - Browse repository at this point
Copy the full SHA 8121bb7View commit details
Commits on Aug 26, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 08c4bf9 - Browse repository at this point
Copy the full SHA 08c4bf9View commit details -
Build: complete cleanup (#12430)
`clean_build` is not called when the task is terminated and there could be some lingering files around. Instead of only deleting the files for the current build, we delete the whole `settings.DOCROOT` path when the build starts.
Configuration menu - View commit details
-
Copy full SHA for dc3a9cf - Browse repository at this point
Copy the full SHA dc3a9cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for eafefbc - Browse repository at this point
Copy the full SHA eafefbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9f56e0 - Browse repository at this point
Copy the full SHA d9f56e0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 15.1.0...15.2.0