Skip to content

Commit afac3f1

Browse files
authored
Fix vale issues (#12532)
1 parent 58061fd commit afac3f1

19 files changed

+24
-24
lines changed

docs/dev/aws-temporary-credentials.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ AWS temporary credentials
22
=========================
33

44
Builders run arbitrary commands provided by the user, while we run the commands in a sandboxed environment (docker),
5-
that shouln't be the only line of defense, as we still interact with the files generated by the user outside docker for some operations.
5+
that shouldn't be the only line of defense, as we still interact with the files generated by the user outside docker for some operations.
66

77
This is why instead of using credentials that have access to all the resources in AWS,
88
we are using credentials that are generated by the `AWS STS service <https://docs.aws.amazon.com/STS/latest/APIReference/welcome.html>`__,

docs/dev/contribute.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ label. The reported issue …
174174

175175
Examples:
176176

177-
- *Refactor namedtuples to dataclasess*
177+
- *Refactor namedtuples to dataclasses*
178178
- *Change font size for the project's title*
179179

180180
… is a valid problem within the code base:

docs/dev/design/build-images.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ on each image without asking the users to change the image selected in their con
3939
Then, when a completely different image appeared and after testing ``testing`` image enough,
4040
we discarded ``stable``, old ``latest`` became the new ``stable`` and old ``testing`` became the new ``latest``.
4141
This produced issues to people pinning their images to any of these names because after this change,
42-
*we changed all the images for all the users* and many build issues arrised!
42+
*we changed all the images for all the users* and many build issues arose!
4343

4444

4545
Goals
@@ -222,7 +222,7 @@ Python versions can be pre-compiled once and expose the output on the S3 for the
222222
.. tip::
223223

224224
Since we are building a special cache for pre-compiled Python versions,
225-
we could use the same method for all the other languages instead of creating a full mirror (many Gigabyes)
225+
we could use the same method for all the other languages instead of creating a full mirror (many Gigabytes)
226226
This simple `bash script`_ download the language sources, compiles it and upload it to S3 without requiring a mirror.
227227
Note that it works in the same way for all the languages, not just for Python.
228228

docs/dev/design/future-builder.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ proposing a clear direction to move forward with intermediate steps keeping back
1616
A lot of things have changed since this document was written.
1717
We have had multiple discussions where we already took some decisions and discarded some of the ideas/details proposed here.
1818
The document was merged as-is without a cleaned up and there could be some inconsistencies.
19-
Note that ``build.jobs`` and ``build.commands`` are already implemented *without definig a contract* yet,
19+
Note that ``build.jobs`` and ``build.commands`` are already implemented *without defining a contract* yet,
2020
and with small differences from the idea described here.
2121

2222
Please, refer to the following links to read more about all the discussions we already had:

docs/dev/design/new-notifications-system.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ Small notes and other considerations
6363
* How do we handle translations?
6464
We should use ``_("This is the message shown to the user")`` in Python code and return the proper translation when they are read.
6565
* Reduce complexity on ``Build`` object (remove ``Build.status`` and ``Build.error`` fields among others).
66-
* Since the ``Build`` object could have more than 1 notification, when showing them, we will sort them by importane: errors, warnings, note, tip.
66+
* Since the ``Build`` object could have more than 1 notification, when showing them, we will sort them by importance: errors, warnings, note, tip.
6767
* In case we need a pretty specific order, we can add an extra field for that, but it adds unnecessary complexity at this point.
6868
* For those notifications that are attached to the ``Project`` or ``Organization``, should it be shown to all the members even if they don't have admin permissions?
6969
If yes, this is good because all of them will be notified but only some of them will be able to take an action.
@@ -452,7 +452,7 @@ Notification update
452452
Backward compatibility
453453
----------------------
454454

455-
It's not strickly required, but if we want, we could extract the current notification logic from:
455+
It's not strictly required, but if we want, we could extract the current notification logic from:
456456

457457
* Django templates
458458

docs/dev/design/secure-api-access-from-builders.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ since it also handles authentication).
161161
Decision
162162
--------
163163

164-
Due to the fact that the required features from knox are not released yet,
164+
Because the required features from knox are not released yet,
165165
we have decided to use DRF API key instead.
166166

167167
Future work

docs/dev/github-app.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ GitHub App
44
Our GitHub App integration consists of a GitHub App (one for each platform, readthedocs.org and readthedocs.com),
55
which can be installed on a user's account or organization.
66

7-
After installing the GitHub App, users can grant acccess to all repositories or select specific repositories,
7+
After installing the GitHub App, users can grant access to all repositories or select specific repositories,
88
this allows Read the Docs to access the repositories and perform actions on them, such as reporting build statuses,
99
and subscribe to events like push and pull request events.
1010

@@ -42,5 +42,5 @@ Security
4242
- Since we make use of the installation to perform actions on the repositories instead of the user's OAuth2 token,
4343
we make sure that only users with admin permissions on the repository can link the repository to a Read the Docs project.
4444
- Once we lose access to a repository (e.g. the installation is uninstalled or revoked, or the project was deselected from the installation),
45-
we remove the remote repository from the database, as we don't want to keep the relation bettween the project and the repository.
45+
we remove the remote repository from the database, as we don't want to keep the relation between the project and the repository.
4646
This is to prevent connecting the repository to the project again without the user's consent if they grant access to the repository again.

docs/user/commercial/sharing.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ you need to authenticate those users against your own system first.
119119
The simplest way to do this is to create an authenticated redirect on your site,
120120
which then redirects to the Read the Docs :ref:`commercial/sharing:secret link`.
121121

122-
This should require very little customization,
122+
This should require minimal customization,
123123
and will ensure that only authenticated users can access the documentation.
124124
The downside is that users won't be able to access the documentation directly from a bookmark,
125125
and will have to go through your site first.

docs/user/guides/best-practice/links.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Good practice ✅
6161
keep original file names rather than going for low-impact URL renaming.
6262
Renaming an article's title is great for the reader and great for SEO,
6363
but this does not have to involve the URL.
64-
* Establish your understanding of the *latest* and :term:`default version` of your documentation at the beginning. Changing their meaning is very disruptive to incoming links.
64+
* Establish your understanding of the *latest* and :term:`default version` of your documentation at the beginning. Changing their meaning is disruptive to incoming links.
6565
* Keep development versions :ref:`hidden <versions:Version states>` so people do not find them on search engines by mistake.
6666
This is the best way to ensure that nobody links to URLs that are intended for development purposes.
6767
* Use a :ref:`version warning notifications <versions:Version warning notifications>` to ensure the reader is aware in case they are reading an old (archived) version.

0 commit comments

Comments
 (0)