feat: move swift from NSURLSession to URLSession #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
requested review from
a team,
darrenyong and
kanadgupta
and removed request for
a team
erunion
changed the title
erunion
approved these changes
Apr 10, 2024
Member
erunion
left a comment
erunion
left a comment
There was a problem hiding this comment.
i don't have any experience with swift but this looks ok to me!
3 tasks
Author
|
@erunion |
Member
|
@zunda-pixel This should be available on ReadMe customer sites sometime next week. |
Author
|
@erunion thanks! |
Member
|
@zunda-pixel This work is now available on ReadMe customer sites. Thanks again! |
Author
|
@erunion thanks! let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Describe in detail what this PR is for.
🧬 QA & Testing
I fixed code in
/httpsnippet/src/targets/swift/urlsession/fixtures/npm run test