Skip to content

feat: update to upstream #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erunion merged 27 commits into from
Jul 16, 2022
Merged

feat: update to upstream #107

erunion merged 27 commits into from
Jul 16, 2022

Conversation

@erunion
Copy link
Member

@erunion erunion commented Jul 15, 2022 •
edited
Loading

🧰 Changes

This updates our fork of HTTPSnippet to the latest work upstream. Beyond the overall Typescript rewrite that happened there not much else has changed:

  • Snippets look better and no longer have unnecessarily quoted object keys or double quotes when we can use single in the following targets and clients:
    • JS → XHR
    • JS → jQuery
    • JS → fetch
    • Node → native
    • Node → unirest
  • Axios (JS + Node)
    • The axios imports to be consistent with how the rest of the snippet looks.
  • Axios (Node-only changes)
    • axios .then() and .catch() thenables are now on their own lines.

🧬 QA & Testing

All normal and integration tests should be passing!

dimitropoulos and others added 21 commits April 26, 2022 08:30
@dimitropoulos
Total Overhaul (but with all the same fixtures!) (#248)
66baca6 
see Kong#248 and the commits therein for more context.  Essentially:
- the original client fixtures were unchanged, which hopefully means the 
- all source code is now in strict mode TypeScript
- tests are now all in jest
- the file structure was reorganized so that everything for a particular client is in one place
- the CLI is updated and now using yargs
- all dependencies were updated and some (i.e. `format.utils`) were able to be removed entirely
- more work left to do (including CI with GitHub Actions, for example), but this is a start
@erunion @dimitropoulos
fix: case where if postData.params is missing some targets crash (#258
c7eae4c 
)

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@erunion
fix: compatibility issues on node 14 with Object.hasOwn() (#252)
998e403
@erunion @dimitropoulos
fix: typo in the httpie style option not being correctly applied (#254
f64080d 
)

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@erunion @dimitropoulos
fix: axios targets not sending x-www-form-urlencoded properly (#255)
cd4bb4c 
Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@erunion @dimitropoulos
feat: addition of a PHP target for Guzzle (#253)
62d158d 
Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@filfreire
Add Github Build Workflow (#250) (#251)
0e0728a 
* Add Github Build Workflow (#250)

* Edit job name

* Replace install with ci on GH workflow

* Add matrix with major node versions (14, 16, 18)

* Disable fail-fast

* Remove node v14 from build GH action
@erunion @dimitropoulos
feat: native upload support in python requests snippets (#259)
411844f 
Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@erunion @dimitropoulos
fix: multipart/form-data header issues with node/js fetch targets (#…
3119335 
…257)

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@erunion @dimitropoulos
fix: headers not being properly applied to R httr snippets (#263)
5e8f161 
Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@filfreire
Fix build workflow dispatch rules (#265)
8ca9771
@filfreire @dimitropoulos
Chore: Remove travis links (#266)
97731b1 
* Remove travis links

* Update README.md

Co-authored-by: Dimitri Mitropoulos <dimitrimitropoulos@gmail.com>
@erunion
Merge remote-tracking branch 'upstream/master' into feat/update-to-up…
d80a1f4 
…stream
@erunion
chore: fixing eslint issues
3271590
@erunion
fix: updating test snapshots
aeaff9a
@erunion
fix: getting the stock target tests all passing
03e796c
@erunion
fix: broken snapshots
f69a0cd
@erunion
fix: adding missing test coverage for addTarget and addTargetClient
e5a77aa
@erunion
fix: build issues
5bcffb3
@erunion
feat: getting the integration tests suite running again
4d85222
@erunion
fix: issues with the docker setup
a63dbc5
@erunion erunion added enhancement New feature or request refactor Issues about tackling technical debt labels Jul 15, 2022
@erunion erunion marked this pull request as ready for review July 16, 2022 23:07
@erunion erunion merged commit df6d56d into main Jul 16, 2022
@erunion erunion deleted the feat/update-to-upstream branch July 16, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request refactor Issues about tackling technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erunion @dimitropoulos @filfreire