Backwards compatibility with Promise v1 API #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
promise-compatibility
branch
2 times, most recently
from
8e4f908 to
dccc2c6
Compare
This simple patch updates this project to target either the current Promise v2 API or the legacy Promise v1 API. While we actively encourage people to use the current Promise v2 API, we still provide active support for the old Promsie v1 API. For the most part, they are fully compatible, see also the https://github.com/reactphp/promise/blob/2.x/CHANGELOG.md for details. The legacy Promise v1 API also supports outdated legacy PHP 5.3 which we understand is still a requirement for a certain non-zero number of projects. That being said, we actively encourage our users to update to the latest version of PHP 7+ for best performance.
clue
force-pushed
the
promise-compatibility
branch
from
dccc2c6 to
71d5504
Compare
jsor
approved these changes
Jan 27, 2019
WyriHaximus
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple patch updates this project to target either the current
Promise v2 API or the legacy Promise v1 API. While we actively encourage
people to use the current Promise v2 API, we still provide active
support for the old Promsie v1 API. For the most part, they are fully
compatible, see also the
https://github.com/reactphp/promise/blob/2.x/CHANGELOG.md for details.
The legacy Promise v1 API also supports outdated legacy PHP 5.3 which we
understand is still a requirement for a certain non-zero number of
projects. That being said, we actively encourage our users to update to
the latest version of PHP 7+ for best performance.
Closes #415
Closes #416