Update dependencies to fix test timeouts on Travis #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Jan 19, 2018
clue
changed the title
clue
changed the title
clue
changed the title
Member
Author
|
After toying around with this to no avail, I decided to not install custom event loop extensions on Travis anymore. Their output is somewhat flaky on Travis and they add a significant overhead and add to total build time. That being said, we're not currently aware of any issues with any of the extensions and I was not able to reproduce any issues locally, so I conclude this is a safe move for now. My vote is that if we find they add value to this test suite, we may add them back again at a later stage 👍 This PR is now ready for review |
jsor
approved these changes
Apr 11, 2018
WyriHaximus
approved these changes
Apr 11, 2018
This was referenced Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Travis build currently times out. It worked successfully after #396 and started failing with #397. I've applied some minor test improvements to react/stream to hopefully fix this issue via reactphp/stream#132.
Builds on top of #396 and #397
Refs reactphp/stream#132