Support multipart parsing for RequestBodyParserMiddleware (file uploads)#226
Conversation
WyriHaximus
changed the title
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Some very nice progress, I like the direction this is heading! 👍
The code currently contains some unclear references and a number of leftover references as it was apparently prepared before the buffer middleware landed. Can you update this?
|
Ping @clue, all your concens have been address and where needed code has been updated. |
|
ping @clue would it be possible to proceed with this PR? |
clue
force-pushed
the
middleware-body-parser-multipart
branch
from
ae498a7 to
bd8b4ff
Compare
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
I've squashed some of your changes and made some minor adjustments to the readme, if you're good with these changes, then let's get this in! 
I still have a number of (minor) outstanding issues, but I'd really love to get this feature shipped 👍 Given that my remarks won't affect the public API, I'd rather address this separately in a follow-up PR.
clue
changed the title
|
🎉 |
4 participants
Follow up on #220 adding multipart support for forms and file uploads
Supersedes / Closes #41
Implements / Closes #105
Implements / Closes #117
Todo: