Form Urlencoded Request Body Parser Middleware#222
Form Urlencoded Request Body Parser Middleware#222WyriHaximus wants to merge 1 commit intoreactphp:masterfrom
Conversation
|
Does this middleware- same as the multipart one- not require that the entire body is received first? If yes- how is the dependency on the It's probably confusion on my side but this implementation feels radically different from what has been committed last year before rolling back with the difference being much more than just middlware stacked in? |
|
@andig it does, that dependency will be expressed through the documentation in the readme. Haven't added that to this PR since we haven't came to the conclusion if this and #223 of a middleware per content type or #220 is the way to go. I understand your confusion, when discussing this with @clue at DPC a few months ago. But #216, #218, and #220 or #222/#223 together make working form and file upload handling. Because I personally would prefer a streaming parser and the new middleware make it easy putting another parser in there, I'm writing a streaming body parser middleware once @reactphp/core settles on #220 vs #222/#223 . (So there is an option for both, plus I have all the code making it a matter of putting it together.) |
|
Closing in favour of #220 as explained here: #220 (comment) |
Split off from #220
Requires #216