Align DocBlock Promise return types#44
Merged
clue merged 1 commit intoreactphp:masterfrom Feb 2, 2021
Merged
Conversation
Currently most of the docblocks provide a return type inside the PromiseInterface like bool or array. This commit aligns it for all methods on the interface.
jsor
approved these changes
Feb 1, 2021
clue
approved these changes
Feb 2, 2021
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
Good to see this is now in line with the README introduced with #34.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently most of the docblocks provide a return type inside the
PromiseInterface like bool or array. This commit aligns it for all
methods on the interface.