Skip to content

Add support for getMultiple(), setMultiple(), deleteMultiple(), clear() and has() (inspired by PSR-16)#32

Merged
clue merged 3 commits intoreactphp:masterfrom
krlv:psr-16_getMultiple_setMultiple
Jan 12, 2019
Merged

Add support for getMultiple(), setMultiple(), deleteMultiple(), clear() and has() (inspired by PSR-16)#32
clue merged 3 commits intoreactphp:masterfrom
krlv:psr-16_getMultiple_setMultiple

Conversation

@krlv
Copy link
Contributor

@krlv krlv commented Oct 26, 2018

Resolves #25

@krlv
Copy link
Contributor Author

krlv commented Oct 26, 2018

Tried to implement #25 the easiest way. Let me know if this approach looks good for you @WyriHaximus

@WyriHaximus WyriHaximus added this to the v0.6.0 milestone Oct 26, 2018
@clue clue added the BC break label Oct 29, 2018
clue
clue reviewed Oct 29, 2018
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krlv Thanks for working on this, I like the direction this is heading!

Does it make sense to add deleteMultiple() and clear() methods as part of this PR?

@krlv
Copy link
Contributor Author

krlv commented Oct 29, 2018 •
edited
Loading

@clue I was thinking about adding deleteMultiple() and clear() methods to this PR as well, if you're OK with this approach for xxxMultiple methods

@krlv
Copy link
Contributor Author

krlv commented Oct 30, 2018

Added following PSR-16 methods:

  • deleteMultiple
  • clear
  • has (not sure if it's really required, added just to be more PSR-16 compliant)

jsor
jsor reviewed Oct 30, 2018
View reviewed changes
@krlv
Copy link
Contributor Author

krlv commented Dec 5, 2018 •
edited
Loading

Just a kind reminder on this PR, guys 😏

I don't really want to be rude or rush you in any way; I know, we all have work to do. I really appreciate what you all guys doing for OSS and PHP community (and especially for Async PHP community!) ❤️

I just want to let you know, that if you have any suggestions or comments on this PR I will be happy to do them!

@jsor
Copy link
Member

jsor commented Dec 5, 2018

Thanks for the reminder 👍

WyriHaximus
WyriHaximus approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clue clue changed the title Add PSR-16 methods support: getMultiple and setMultiple Add support for getMultiple(), setMultiple(), deleteMultiple(), clear() and has() (inspired by PSR-16) Jan 11, 2019
@clue
Copy link
Member

clue commented Jan 12, 2019

@krlv Thank you very much for this most excellent contribution and your high quality PR including tests and documentation! If only open source would always be that easy 😊 Thank you for your patience, now let's finally get this shipped! :shipit: 🎉

Also, keep it coming 👍

@clue clue merged commit 8012204 into reactphp:master Jan 12, 2019
@krlv krlv deleted the psr-16_getMultiple_setMultiple branch January 13, 2019 05:26
@clue clue mentioned this pull request Jul 3, 2019
Merged
@clue clue mentioned this pull request Jul 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees

No one assigned

Labels

BC break new feature

Projects

None yet

Milestone

v0.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@krlv @jsor @clue @WyriHaximus