Fix flatMap request accounting for resumed errors - #4307
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
Signed-off-by: Goutam Adwant <workwithgoutam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix details
Flux.flatMapno longer over-requests from upstream when aCallableinner source throws and the error is resumed byonErrorContinue.The
Callableerror path now accounts for the skipped source value once through the common post-error bookkeeping path, while preserving delayed-error behavior for errors that are not resumed. The regression test verifies that two resumedCallablefailures do not trigger early upstream replenishment.Tests:
./gradlew :reactor-core:test --tests reactor.core.publisher.FluxFlatMapTest --tests reactor.core.publisher.OnNextFailureStrategyTest --max-workers=2 --no-build-cache --rerun-tasks./gradlew spotlessCheck --max-workers=2 --no-build-cacheFixes #4290.