Resolve required keyword order for partial reactive properties. - #240
Merged
Conversation
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #237
What is the current behavior?
#237
What is the new behavior?
Documentation Updates:
README.mdto document new[Reactive]attribute features, including initializer support,SetModifier,Inheritance, andUseRequiredoptions. These new features enhance flexibility in defining reactive properties.New Features for Property Generation:
requiredpartial properties inInternalTestViewModel, allowing developers to define required properties with the[Reactive]attribute.Source Generator Enhancements:
ReactiveGenerator.Execute.csto usepropertySymbol.IsRequiredfor determining if a property is required, replacing the previous approach of relying on attribute arguments. This ensures better alignment with C# language features.ReactiveGenerator.Execute.csto reorder modifiers for consistency, placingUseRequiredbeforepartialModifier.What might this PR break?
Previous releases would have failed to compile, therefore no expected changes
Please check if the PR fulfills these requirements
Other information: