fix: use click outside to trigger also when previous click was on the target element #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I tried out this code and it didn't work. The root cause is that |
…ng a scrollbar. when clicking outside after interacting with the tooltips scrollbar, the on close will not be fired when using the click event trigger. We need to use the mouseup trigger in that case. Signed-off-by: David Edler <david.edler@canonical.com>
edlerd
force-pushed
the
fix-overlay-close
branch
from
fc317fd to
bfcfc09
Compare
Contributor
Author
Right, got it. So to fix the issue, we don't need to change the implementation, but use a different root close trigger. I added an example as this is a pretty nasty edge case. |
Collaborator
|
This is fixed in #112 We won't need the new example. Thanks for taking a look at this though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
This fixes and edge case, where the overlay contains a scrollbar and the user scrolls in the overlay. then clicks outside, the on close is not triggered immediately. with this fix it is triggerred on first click outside. Before the on close was only triggered on the second click outside.
See downstream bug in react-bootstrap/react-bootstrap#6836