Skip to content

Refactor(Button): update ViewComponent type and enhance documentation… - #4026

Merged
theianmay merged 4 commits into
react-native-elements:nextfrom
OpenSrcContributions:main
May 21, 2026
Merged

Refactor(Button): update ViewComponent type and enhance documentation…#4026
theianmay merged 4 commits into
react-native-elements:nextfrom
OpenSrcContributions:main

Conversation

@codewithshinde

Copy link
Copy Markdown
Contributor

… examples. Include usage of expo-linear-gradient and Custom View Component in the Button

Motivation

Fixes # (issue)
Update the LinearGradient Docs usage, and also update the type of ViewComponent
from
typeof React.Component
to
React.ComponentType<any>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally- No, build or test failures

  • Jest Unit Test
  • Checked with example app

Checklist

  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

… examples. Include usage of expo-linear-gradient and Custom View Component in Button
@codecov

codecov Bot commented Feb 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.40%. Comparing base (70290c6) to head (e774673).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4026   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          90       90           
  Lines        2141     2141           
  Branches      954      954           
=======================================
  Hits         1700     1700           
  Misses        439      439           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theianmay
theianmay self-requested a review February 19, 2026 21:48
@theianmay theianmay self-assigned this Feb 19, 2026
@theianmay theianmay added the component: Button Issue related to Button Component label Feb 19, 2026
@github-project-automation github-project-automation Bot moved this to In Progress 🚧 in Community Roadmap 🛣 Feb 19, 2026
@theianmay theianmay added this to the v5.0.1 milestone Feb 19, 2026
Comment thread packages/base/src/Button/Button.usage.tsx Outdated
Comment thread packages/base/src/Button/Button.usage.tsx Outdated
Comment thread website/docs/components/Button.mdx Outdated
codewithshinde and others added 3 commits April 16, 2026 20:13
Co-authored-by: Marcos Veloso <marcosvelosodev@gmail.com>
Co-authored-by: Marcos Veloso <marcosvelosodev@gmail.com>
Co-authored-by: Marcos Veloso <marcosvelosodev@gmail.com>

@codewithshinde codewithshinde left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the changes

@theianmay theianmay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-project-automation github-project-automation Bot moved this from In Progress 🚧 to Ready to Merge (PRs) ✨ in Community Roadmap 🛣 May 21, 2026
@theianmay
theianmay merged commit 32ae0ed into react-native-elements:next May 21, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Merge (PRs) ✨ to Closed or Merged 🏁 in Community Roadmap 🛣 May 21, 2026
github-actions Bot pushed a commit that referenced this pull request May 21, 2026
Refactor(Button): update ViewComponent type and enhance documentation…
github-actions Bot pushed a commit that referenced this pull request May 21, 2026
Refactor(Button): update ViewComponent type and enhance documentation…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Button Issue related to Button Component

Projects

Status: Closed or Merged 🏁

Development

Successfully merging this pull request may close these issues.

3 participants