feat(Header): add edges support for SafeAreaView - #3741
Merged
arpitBhalla merged 6 commits intoJan 24, 2023
Merged
Conversation
added 2 commits
January 20, 2023 19:11
…pport proper padding disable for web
Codecov Report
@@ Coverage Diff @@
## next #3741 +/- ##
==========================================
+ Coverage 79.42% 79.44% +0.01%
==========================================
Files 87 87
Lines 1823 1824 +1
Branches 806 796 -10
==========================================
+ Hits 1448 1449 +1
Misses 370 370
Partials 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
arpitBhalla
changed the title
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
Co-authored-by: thekevshow <kevin.kelly@> Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
Co-authored-by: thekevshow <kevin.kelly@> Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pport proper padding disable for web
Motivation
I was having issues using the header within a modal, which is a very useful component, and I am sure there could be other use cases. To be able to control the SafeAreaView edges, because on a PWA particularly this causes extra padding etc in unwanted areas.
Fixes # Header SafeAreaViews that I have somewhat seen could have been maybe fixed within the issues backlog.
Type of change
How Has This Been Tested?
I have used the project change within my own code base to test and ran existing tests to make sure no breaking changes would occur.
exampleappChecklist
yarn docs-build-api