fix(theme): add ListItemSwipable to ComponentTheme interface - #3691
Merged
arpitBhalla merged 1 commit intoNov 26, 2022
Merged
Conversation
A [ThemeProvider][1] allows users to specify default props per type of component. Components are identified by a theme key. For swipeable `ListItems`, [the key is `ListItemSwipeable`][2]. The props are correctly applied, but `ListItemSwipeable` is missing from the `ComponentTheme` interface, which makes TypeScript complain. This adds the missing theme key. Resolves: react-native-elements#3690 [1]: https://reactnativeelements.com/docs/customizing#using-themeprovider [2]: https://reactnativeelements.com/docs/components/listitem_swipeable
Codecov Report
@@ Coverage Diff @@
## next #3691 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 87 87
Lines 1821 1821
Branches 811 811
=======================================
Hits 1446 1446
Misses 370 370
Partials 5 5 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ListItemSwipable to ComponentTheme interface
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 26, 2022
A [ThemeProvider][1] allows users to specify default props per type of component. Components are identified by a theme key. For swipeable `ListItems`, [the key is `ListItemSwipeable`][2]. The props are correctly applied, but `ListItemSwipeable` is missing from the `ComponentTheme` interface, which makes TypeScript complain. This adds the missing theme key. Resolves: #3690 [1]: https://reactnativeelements.com/docs/customizing#using-themeprovider [2]: https://reactnativeelements.com/docs/components/listitem_swipeable
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 26, 2022
A [ThemeProvider][1] allows users to specify default props per type of component. Components are identified by a theme key. For swipeable `ListItems`, [the key is `ListItemSwipeable`][2]. The props are correctly applied, but `ListItemSwipeable` is missing from the `ComponentTheme` interface, which makes TypeScript complain. This adds the missing theme key. Resolves: #3690 [1]: https://reactnativeelements.com/docs/customizing#using-themeprovider [2]: https://reactnativeelements.com/docs/components/listitem_swipeable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A ThemeProvider allows users to specify default props per type of component. Components are identified by a theme key. For swipeable
ListItems, the key isListItemSwipeable.The props are correctly applied, but
ListItemSwipeableis missing from theComponentThemeinterface, which makes TypeScript complain.Example theme:
Error:
This adds the missing theme key.
Fixes #3690
Type of change
How Has This Been Tested?
exampleappChecklist
yarn docs-build-apiAdditional context