Skip to content

feat(ThemeProvider)!: restructure default component theme - #3582

Merged
arpitBhalla merged 7 commits into
react-native-elements:nextfrom
arpitBhalla:component-theme
Jul 31, 2022
Merged

feat(ThemeProvider)!: restructure default component theme#3582
arpitBhalla merged 7 commits into
react-native-elements:nextfrom
arpitBhalla:component-theme

Conversation

@arpitBhalla

@arpitBhalla arpitBhalla commented Jul 19, 2022

Copy link
Copy Markdown
Member
import { createTheme } from '@rneui/themed';

const myTheme = createTheme({
+  components: {
    Button:{
      titleStyle: {
        color: 'red'
      },
    },
+  },
});

@arpitBhalla arpitBhalla linked an issue Jul 19, 2022 that may be closed by this pull request
1 task
@arpitBhalla
arpitBhalla marked this pull request as ready for review July 31, 2022 19:36
@codecov

codecov Bot commented Jul 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3582 (2ae3373) into next (182861e) will decrease coverage by 0.23%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             next    #3582      +/-   ##
==========================================
- Coverage   79.61%   79.38%   -0.24%     
==========================================
  Files          87       87              
  Lines        1805     1809       +4     
  Branches      799      801       +2     
==========================================
- Hits         1437     1436       -1     
- Misses        362      367       +5     
  Partials        6        6              
Impacted Files Coverage Δ
packages/themed/src/config/withTheme.tsx 86.48% <75.00%> (+0.37%) ⬆️
packages/themed/src/config/ThemeProvider.tsx 65.95% <100.00%> (-9.05%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom theme properties missing when using withTheme

1 participant