feat(Tab): add horizontally scrollable Tab.Items - #3336
Merged
arpitBhalla merged 7 commits intoFeb 12, 2022
Conversation
…ong with scrollHandler( ) function which syncs the scrollview with active tab.
arpitBhalla
changed the title
entrymaster
commented
Feb 4, 2022
entrymaster
left a comment
entrymaster
left a comment
Contributor
Author
There was a problem hiding this comment.
I have removed some unnecessary code.
arpitBhalla
requested changes
Feb 12, 2022
Member
|
@entrymaster I made few more changes, so you can skip review change request, Thank you for your contribution 🎉 |
This was
linked to
issues
Feb 12, 2022
Codecov Report
@@ Coverage Diff @@
## next #3336 +/- ##
==========================================
- Coverage 79.97% 79.07% -0.91%
==========================================
Files 88 88
Lines 1663 1701 +38
Branches 732 744 +12
==========================================
+ Hits 1330 1345 +15
- Misses 328 351 +23
Partials 5 5
Continue to review full report at Codecov.
|
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 12, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 12, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 12, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
arpitBhalla
added a commit
that referenced
this pull request
Mar 17, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
arpitBhalla
added a commit
that referenced
this pull request
Mar 19, 2022
Co-authored-by: Arpit Bhalla <55053424+arpitBhalla@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat:
Fix: