Update ButtonGroup.tsx - #3260
Closed
JimTeva wants to merge 2 commits into
Closed
Conversation
JimTeva
commented
Dec 10, 2021
JimTeva
commented
- TS complains on prop "buttons" when receiving a variable with type {element: JSX.Element;}[]
- The documentation indicates: const buttons = [{ element: component1 }, { element: component2 }, { element: component3 }]
- So Typescript should not complain
- In order to not break things I only added type {element: React.ReactElement} and didn't remove React.ReactElement<{}>
- TS complains on prop "buttons" when receiving a variable with type {element: JSX.Element;}[] which is odd
- The documentation indicates: const buttons = [{ element: component1 }, { element: component2 }, { element: component3 }]
- So Typescript should not complain
- In order to not break things I only added type {element: React.ReactElement} and didn't remove React.ReactElement<{}>
|
✔️ Deploy Preview for react-native-elements canceled. 🔨 Explore the source changes: d075033 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native-elements/deploys/61c362cba52d3e000877d1bb |
Member
|
I think #3220 will do the work, we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.