Disables Input While Using Portal Unless keepFocusOnInput is Selected #2079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… open, but also gives access to properly using the input if they have the portal prop and the keepFocusOnInput prop selected
americool
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using the portal you can still type an initial valid start date, however once said start date is finished, you lose focus off the input itself and can only enter the next date via the calendar. It was suggested in response to #2078 that we should simply disable the input while the calendar portal is open. This does that, but also allows the keepFocusOnInput prop to actually work with the portal, such that if you have both a portal prop and the keepFocusOnInput prop you can type in the entire start/end date. These two small changes make both possible.