fix: preventing redirects from live preview #6858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VibhorJaiswal
changed the title
kyletsang
reviewed
Nov 14, 2024
www/src/theme/Playground/Preview.tsx
Outdated
|
|
||
| const handleCustomRedirect = (e) => { | ||
| const target = e.target as HTMLElement; | ||
| if (target.closest('a[href]')) { |
Member
There was a problem hiding this comment.
Can you try this?
if (e.target.tagName === 'A') {
e.preventDefault();
}
www/src/theme/Playground/Preview.tsx
Outdated
| ); | ||
|
|
||
|
|
||
| const handleCustomRedirect = (e) => { |
Member
There was a problem hiding this comment.
Can you wrap this callback with a useEventCallback from @restart/hooks. Also add a type to e and remove the cast on line 60
Contributor
Author
|
Hi! @kyletsang, I've implemented the changes based on your suggestions. Could you please review and let me know if it looks good now? |
kyletsang
approved these changes
Nov 18, 2024
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6843
Hi! as discussed in PR #6852
to prevent the action on all anchors within code examples within the playground component, here is the revised solution.