fix: switch from defaultProps to JS default params #6823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madflow
commented
Jul 2, 2024
madflow
commented
- We are using 3rd Party Integrations which only support BS4
- We would like to use React 18.3 without warnings
- I tinkered with the prop types and basically went over the low hanging fruit (as far as I can tell :S)
- I have read Remove defaultProps for React 18.3.0 #6547 , maybe we can make some small changes and make it a little bit better for BS4?
madflow
force-pushed
the
bs4-default-props
branch
from
fb3c257 to
4471cc9
Compare
madflow
force-pushed
the
bs4-default-props
branch
from
4471cc9 to
b2bdae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.