cmd/ncdu: add unit tests for the TUI#9489
Open
acme wants to merge 5 commits into
Open
Conversation
Uses tcell's SimulationScreen to render the UI without a real terminal. Covers initialisation defaults, screen layout (header, path bar, footer), cursor navigation, sorting, popup boxes, and visual select mode.
setupDir selects on rootChan and errChan. For small remotes both can be ready simultaneously and if errChan won the race, root was still nil when passed to setCurrentDir. Fix by draining rootChan first if root hasn't been received yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Like #9480 I noticed that the ncdu command text user interface didn't have any tests. Turns out tcell makes it easy to test.
Uses tcell's SimulationScreen to render the UI without a real terminal. Covers initialisation defaults, screen layout (header, path bar, footer), cursor navigation, sorting, popup boxes, and visual select mode.
Was the change discussed in an issue or in the forum before?
No
Checklist