http: factor single-file List helper and add t.Helper() to test helpers#9422
Open
eghuro wants to merge 2 commits into
Open
http: factor single-file List helper and add t.Helper() to test helpers#9422eghuro wants to merge 2 commits into
eghuro wants to merge 2 commits into
Conversation
TestIsAFileSubDir didn't assert the ErrDirNotFound branch for non-root List() in single-file mode, so the new behaviour was asymmetrically covered. Factor an assertSingleFileList helper that both TestIsAFileRoot and TestIsAFileSubDir use, and add t.Helper() to the existing prepare/prepareServer/testListRoot fixtures so failures report at the call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
TestIsAFileSubDir didn't assert the ErrDirNotFound branch for non-root List() in single-file mode, so the new behaviour was asymmetrically covered. Factor an assertSingleFileList helper that both TestIsAFileRoot and TestIsAFileSubDir use, and add t.Helper() to the existing prepare/prepareServer/testListRoot fixtures so failures report at the call site.
Was the change discussed in an issue or in the forum before?
No
Checklist