Repository navigation
SWR matplotlib__matplotlib-1813 - #72
Open
richeshgupta wants to merge 1 commit into
Open
richeshgupta wants to merge 1 commit into
richeshgupta wants to merge 1 commit into
Conversation
| raise ImportError("Gtk3 backend requires pygobject to be installed.") | ||
|
|
||
| try: | ||
| gi.require_version("Gtk", "3.0") |
There was a problem hiding this comment.
[MEDIUM] New pygobject and Gtk 3.0 import-error paths have no test coverage
Issue
The diff adds two import-time error branches — ImportError when pygobject is missing and ValueError from gi.require_version translated to ImportError — but no test exercises either, so the new exception translation and user-facing messages can regress silently. The Gtk 3.0 message is already malformed.
Evidence
SUSPECTED: a test that mocks gi in sys.modules — one case with gi absent, one with gi.require_version raising ValueError — imports backend_gtk3 and asserts both ImportError messages; it would fail today on the garbled 'Gtk3 backend gtk3 development files to be installed.' message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWRBench case matplotlib__matplotlib-1813: pinned base f30dc0a to head bb138bb of matplotlib#1813. Benchmark replay, not for merge.