Skip to content

SWR matplotlib__matplotlib-1813 - #72

Open
richeshgupta wants to merge 1 commit into
swr-base-bb138bbfrom
swr-head-bb138bb
Open

richeshgupta wants to merge 1 commit into
swr-base-bb138bbfrom
swr-head-bb138bb

Conversation

@richeshgupta

Copy link
Copy Markdown

SWRBench case matplotlib__matplotlib-1813: pinned base f30dc0a to head bb138bb of matplotlib#1813. Benchmark replay, not for merge.

@razorpay-slash razorpay-slash Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated code review

Reviewed up to bb138bb.
All 5 reviewers completed.

raise ImportError("Gtk3 backend requires pygobject to be installed.")

try:
gi.require_version("Gtk", "3.0")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] New pygobject and Gtk 3.0 import-error paths have no test coverage

Issue

The diff adds two import-time error branches — ImportError when pygobject is missing and ValueError from gi.require_version translated to ImportError — but no test exercises either, so the new exception translation and user-facing messages can regress silently. The Gtk 3.0 message is already malformed.

Evidence

SUSPECTED: a test that mocks gi in sys.modules — one case with gi absent, one with gi.require_version raising ValueError — imports backend_gtk3 and asserts both ImportError messages; it would fail today on the garbled 'Gtk3 backend gtk3 development files to be installed.' message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants