Repository navigation
SWR matplotlib__matplotlib-10206 - #48
Open
richeshgupta wants to merge 2 commits into
Open
richeshgupta wants to merge 2 commits into
richeshgupta wants to merge 2 commits into
Conversation
![razorpay-slash[bot]](https://avatars.githubusercontent.com/in/4548214?s=60&v=4){kind=small}
|
|
||
| def __getitem__(self, item): | ||
| return Quantity(self.magnitude[item], self.units) | ||
| if iterable(self.magnitude): |
There was a problem hiding this comment.
[MEDIUM] The added getitem branch check is a no-op; both branches are identical, so the units change gains no new coverage
Issue
The new if iterable(self.magnitude) guard returns the same expression in both branches, so it cannot exercise the scalar-magnitude path and adds no behavior. It is the only test-file change in this pull request, so the numlike early return in Axis.convert_units and the now-unguarded date2num call in DateConverter.convert gain no new coverage.
Evidence
CONFIRMED: both added branches are textually return Quantity(self.magnitude[item], self.units), so the condition cannot change any outcome; the diff touches no other test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWRBench case matplotlib__matplotlib-10206: pinned base 1f3699c to head ca00cca of matplotlib#10206. Benchmark replay, not for merge.