adding utf8 encoding to documents data#239
Conversation
|
Hi @MohKamal, thanks for the contribution. Could you check code format? Try using Also, could you provide a simple test that verifies correct behavior? I've seen this one in the codebase, is it passing after the change? |
|
@MohKamal To proceed to merge, please address my previous comment - once the test (verifying expected behavior) is created and passing (and the skip is removed from |
Hi @poissoncorp, Thank you for your feedback, I will do it, I was busy a little bit. |
|
@MohKamal could you amend after |
Yes, done, sorry forgot applying black before pushing! |
|
To proceed, please fix failing tests. Many thanks 🙏 |
I see that the emojis are correctly saved and retrieved, do i change the test string from "\ud83d\ude21\ud83d\ude21\ud83e\udd2c\ud83d\ude00" to "😡😡🤬😀" ? |
@MohKamal, any idea why those aren't passing? If that's not something critical, we can safely remove that. |
i can escape them ""\ud83d\ude21\ud83d\ude21\ud83e\udd2c\ud83d\ude00" |
|
I've researched on this myself. Remove the Pythonic \u signs and leave just emojis Like this:
I'll run tests, and merge if passing 👍 |
Encode JSON data as UTF-8 before sending requests to properly support non-ASCII characters.