catch Exception and add some invented type

ricardclau · ricardclau · commit 0a53610a01e5 · 2014-08-23T15:58:13.000+01:00
diff --git a/src/Ladybug/Type/Object/Container.php b/src/Ladybug/Type/Object/Container.php
@@ -386,7 +386,12 @@ protected function loadClassMethods(\ReflectionClass $reflectedObject)
                     $methodParameter = new MethodParameter();
                     $methodParameter->setName($methodParameterReflected->getName());
 
-                    $class = $methodParameterReflected->getClass();
+                    try {
+                        $class = $methodParameterReflected->getClass();
+                    } catch (\ReflectionException $e) {
+                        // This happens if the Class does not exist
+                        $methodParameter->setType('Wrong_Typehint!');
+                    }
 
                     if ($class instanceof \ReflectionClass) {
                         $methodParameter->setType($class->getName());
diff --git a/tests/Ladybug/Tests/Type/Object/BadTypeHintedParameterContainerTest.php b/tests/Ladybug/Tests/Type/Object/BadTypeHintedParameterContainerTest.php
@@ -0,0 +1,70 @@
+<?php
+
+namespace Ladybug\Tests\Type\Object;
+
+use Ladybug\Inspector\InspectorManager;
+use Ladybug\Metadata\MetadataResolver;
+use Ladybug\Type;
+
+use \Mockery as m;
+
+class BadTypeHintedParameterContainerTest extends \PHPUnit_Framework_TestCase
+{
+    /** @var Type\Object $type */
+    protected $type;
+
+    protected function setUp()
+    {
+        $factory = new Type\FactoryType();
+        $factory->add(new Type\Null(), 'type_null');
+
+        $managerInspectorMock = m::mock('Ladybug\Inspector\InspectorManager');
+        $managerInspectorMock->shouldReceive('get')->andReturn(null);
+
+        $metadataResolverMock = m::mock('Ladybug\Metadata\MetadataResolver');
+        $metadataResolverMock->shouldReceive('has')->andReturn(false);
+
+        $this->type = new Type\Object\Container(8, $factory, $managerInspectorMock, $metadataResolverMock);
+    }
+
+    protected function tearDown()
+    {
+        $this->type = null;
+    }
+
+    public function testDumperDoesNotCrashOnWrongTypeHints()
+    {
+        $var = new Problematic();
+        $this->type->load($var);
+
+        // class info
+        $this->assertEquals('Ladybug\Tests\Type\Object\Problematic', $this->type->getClassName());
+        $this->assertEquals(__FILE__, $this->type->getClassFile());
+
+        $this->assertCount(2, $this->type->getClassMethods());
+
+        $privateMethod = $this->type->getMethodByName('privateFunction');
+        $this->assertCount(2, $privateMethod->getParameters());
+
+        $parameter1 = $privateMethod->getParameterByName('that');
+        $this->assertNull($parameter1->getType());
+        $this->assertFalse($parameter1->isReference());
+
+        $badTypeHinted = $privateMethod->getParameterByName('badTypeHinted');
+        $this->assertEquals('Wrong_Typehint!', $badTypeHinted->getType());
+        $this->assertFalse($badTypeHinted->isReference());
+        $this->assertInstanceOf('Ladybug\Type\Null', $badTypeHinted->getDefaultValue());
+    }
+}
+
+class Problematic
+{
+    public function publicFunction()
+    {
+        $this->privateFunction($this, null);
+    }
+
+    private function privateFunction($that, BadTypeHint $badTypeHinted = null)
+    {
+    }
+}
