ignore cmake/ directory in bazel source file checks#2936
Conversation
kilograham
changed the title
will-v-pi
left a comment
will-v-pi
left a comment
There was a problem hiding this comment.
This doesn't fix the issue you're seeing in #2921 - you also need to change git_ls_files_by_extension to only return files in these paths.
Also, it's not just files under src and test that should be checked, it should also check tools/pioasm, so I think excluding cmake is possibly the better option than explicitly specifying paths to search?
A fix could be to revert this change and just add
bazel_files = [f for f in bazel_files if not f.is_relative_to("cmake")]before return bazel_files in git_ls_files_by_extension, to exclude the files under cmake
kilograham
force-pushed
the
relax-bazel-check
branch
from
260baf0 to
53ce06f
Compare
kilograham
changed the title
|
i have force pushed your change. if you are feeling keen @will-v-pi can you fix it to not complain if you have board definitions headers which aren't checked it ;-) |
I think it already shouldn't complain about that, as the use of |
2 participants
cc @armandomontanez