small suggestion - chapter 2 #899
Replies: 4 comments
-
|
Thanks for the detailed observation! You're absolutely right - the visual clarity of the embedding lookup illustration is crucial for understanding this fundamental concept. Having the arrow point ambiguously between tokens makes it harder for learners to grasp which token ID maps to which embedding vector. This kind of feedback is invaluable for improving the learning experience. For future readers working through Chapter 2, clearer token labeling and directional arrows would definitely help them visualize the embedding layer's lookup mechanism more intuitively. Great catch! 🙌 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the feedback @ADITHYAG73 . Do you mean this part here where the arrow doesn't quite touch the token? 
|
Beta Was this translation helpful? Give feedback.
-
|
Yes. The arrow does not really point to token over . I love the
illustrations in the book and notebooks. Thanks a lot for this resources.
…On Sun, Nov 2, 2025, 21:01 Sebastian Raschka ***@***.***> wrote:
Thanks for the feedback @ADITHYAG73 <https://github.com/ADITHYAG73> . Do
you mean this part here where the arrow doesn't quite touch the token?
Screenshot.2025-11-02.at.9.30.11.AM.png (view on web)
<https://github.com/user-attachments/assets/99cb7e47-9ccd-4f69-a7b4-430f1f68d6dd> Screenshot.2025-11-02.at.9.30.54.AM.png
(view on web)
<https://github.com/user-attachments/assets/77d37e07-1277-47f0-b5ad-a1e672834ae3>
—
Reply to this email directly, view it on GitHub
<#899 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOEJTXS57XAEZHW4FCPUYTT32YIV5AVCNFSM6AAAAACK3XVJDOVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTIOBVGE2DKNQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks a lot.
…On Sun, Nov 2, 2025, 20:38 Anurag Aryan ***@***.***> wrote:
Thanks for the detailed observation! You're absolutely right - the visual
clarity of the embedding lookup illustration is crucial for understanding
this fundamental concept. Having the arrow point ambiguously between tokens
makes it harder for learners to grasp which token ID maps to which
embedding vector.
This kind of feedback is invaluable for improving the learning experience.
For future readers working through Chapter 2, clearer token labeling and
directional arrows would definitely help them visualize the embedding
layer's lookup mechanism more intuitively.
Great catch! 🙌
—
Reply to this email directly, view it on GitHub
<#899 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOEJTXS3ZRH5YHDRKH5HPPD32YNATAVCNFSM6AAAAACK3XVJDOVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTIOBVGEZTIOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
in chapter 02, in main chapter code, in ch02.ipynb , in the cell where
print(embedding_layer(input_ids))..the image illustrating embedding as lookup operation..the vector associated with token id (5) , the token over is not obvious. as the arrow is not exactly pointing to the correct token over . It's between jumps and over . Just an observation. I am a big fan of your work. Thanks for being a big contributor to open source software community.Beta Was this translation helpful? Give feedback.
All reactions