Interactive page size and hint how to quit #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Edler <david.edler@canonical.com>
raineorshine
force-pushed
the
interactive-page
branch
from
36ae385 to
2cd88e4
Compare
raineorshine
approved these changes
Nov 12, 2024
Owner
raineorshine
left a comment
raineorshine
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
The dynamic page size looks good.
Thank you for the suggestion for the interactive mode help, although I think in this case I would like to keep the instructions minimal and not have to print something that should be fairly obvious to most people. Interactive mode can be cancelled with Escape or Ctrl + C which are both highly conventional, and per #1414 I would be open to the addition of q to quit. Again just a personal preference to keep the instructions as terse as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done