Add setup.py, resolve name shadowing #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`input` shadows a built-in name, which can cause bugs, confusion, and unhappy IDEs.
clbarnes
force-pushed
the
clbarnes-dev
branch
2 times, most recently
from
b3404db to
454a52c
Compare
This allows resnet.py to be used as a library in a much more accessible fashion.
The py2 build using the theano backend breaks unless mkl is installed manually and an environment variable set.
|
I've managed to install your version with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pyallows others to use theResnetBuilderin a more tidy and traceable way.inputwere renamed toinput_datato resolve name clashes with the builtininputVersioning is left up to @raghakot