-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rack/rack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.7
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: rack/rack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.2.8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 7 commits
- 8 files changed
- 6 contributors
Commits on Apr 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c4245c5 - Browse repository at this point
Copy the full SHA c4245c5View commit details
Commits on May 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e7f4869 - Browse repository at this point
Copy the full SHA e7f4869View commit details
Commits on Jul 15, 2023
-
Backports commit 9cad48e to version 2.2
Configuration menu - View commit details
-
Copy full SHA for 287fe43 - Browse repository at this point
Copy the full SHA 287fe43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fdcf1f - Browse repository at this point
Copy the full SHA 1fdcf1fView commit details
Commits on Jul 31, 2023
-
Fix inefficient assert pattern in Rack::Lint (#2101)
Partial backport of 1970771 Differences from original commit: - `#assert` is not deprecated - `include Assertion` is not removed - The assertion in `check_status` is the 2-2-stable version since the SPEC [change][1] to require statuses to be integers was merged before this - `#dump` was added to the `REQUEST_METHOD` assertion [after][2] the original commit, so it was added here as well This fixes an issue encountered when adding `Rack::Lint` to the Rails test suite. Rails puts a lazily evaluated class inside the request env that has the potential to raise when converted to a string. Since this assertion in `Rack::Lint` calls `#inspect` on `env` whether or not `env` is a `Hash`, the lazily evaluated class would raise at that point and prevent the rest of `Rack::Lint` from validating the conformity of the request. By backporting this change, `#inspect` is now only called when the `LintError` would be raised which avoids the problem. [1]: ba25ade [2]: b426cc2 Co-authored-by: Benoit Daloze <eregontp@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cee73b3 - Browse repository at this point
Copy the full SHA cee73b3View commit details -
It looks like this has been out of sync since additional assertions were [added][1] to `Rack::Lint` concerning `SERVER_PORT`, `SERVER_NAME`, and `HTTP_HOST`. [1]: 290523f
Configuration menu - View commit details
-
Copy full SHA for 0a46487 - Browse repository at this point
Copy the full SHA 0a46487View commit details -
Configuration menu - View commit details
-
Copy full SHA for f169ff7 - Browse repository at this point
Copy the full SHA f169ff7View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.2.7...v2.2.8