Skip to content

Add e-content/entry-content using the_content filter #276

Open

Description

@dshanske

I'd like to propose, and am willing to do the PR....that entry-content and e-content be wrapped around the_content at a high priority through the filter. This means anything added to the_content dynamically would be outside the_content.

Since people put ads and other things in there...this would keep them out when parsed.

Activity

  1. raamdev commented on Jun 27, 2017

    @raamdev
    Owner

    Are you referring to the e-content and entry-content classes? Can you point me to a line in the source code to elaborate?

  2. dshanske commented on Jun 27, 2017

    @dshanske
    ContributorAuthor

    I am. I will try a PR to outline the issue. I want to give some time. The Indieweb Summit was this weekend and there were new people who were struggling to set things up

  3. dshanske commented on Jun 27, 2017

    @dshanske
    ContributorAuthor

    I do this in my now broken mf2_s fork of _s. The issue being that anything added to the_content is inside e-content. But if you add e-content to the_content then it will wrap only around the actual post_content.

  4. dshanske commented on Jul 2, 2017

    @dshanske
    ContributorAuthor

    @raamdev I have been working on fixes and improvements in my fork in a fixes branch if you want to have a look

  5. raamdev commented on Jul 3, 2017

    @raamdev
    Owner

    @dshanske Looks good so far. I see that the entry-content div is now missing in dshanske@ea4de5d. Were you thinking that the e-content div would go inside an entry-content div?

    This means anything added to the_content dynamically would be outside the_content.

    How would something added to the the_content be outside the_content?

  6. dshanske commented on Jul 3, 2017

    @dshanske
    ContributorAuthor

    Omitting entry-content was an oversight. It is fine to have it for backcompat.

    Outside the post content. I am basically wrapping the content created in the editor from dynamically added stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions