remove envvar printing from check_built() #2621
Open
tanho63 wants to merge 4 commits intor-lib:mainfrom
Open
Conversation
tanho63
changed the title
check_built() check_built()
hadley
reviewed
Sep 26, 2025
| env_vars <- check_env_vars(cran, remote, incoming, force_suggests, env_vars) | ||
| if (!quiet) { | ||
| cat_rule("Checking", col = "cyan", line = 2) | ||
| show_env_vars(env_vars) |
Member
There was a problem hiding this comment.
See here I'd explicitly filter out _R_CHECK_ env vars since we know that rcmdcheck will handle them.
Member
|
Only need to merge this if we merge the related rcmdcheck change and this ensures that we don't print the same env vars multiple times. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[tidy dev day 2025] part of r-lib/rcmdcheck#237:
rcmdcheck::rcmdcheck()now prints all associated r check environment variables as well as not cran, so we can remove this feature fromdevtools::check().