Draft
Conversation
idrissneumann
force-pushed
the
feat_highlight
branch
from
8451e7b to
47c1868
Compare
idrissneumann
force-pushed
the
feat_highlight
branch
from
47c1868 to
b71b27a
Compare
Collaborator
Author
|
First version, we'll see if we need to improve the parser using a lucene dependancy in a second version: 
|
idrissneumann
force-pushed
the
feat_highlight
branch
from
22424da to
2630e2b
Compare
Contributor
|
Let's not merge this as is. I will work on quickwit side to return the list of search keywords in the elasticsearch response so that we just have to add them to the dataframe. |
Collaborator
Author
I just put this pr in draft again, I'll rework it when the quickwit response will provide the keywords. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.