Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1686dd7e6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
An empty range skipped the request, so a missing blob read as empty instead of NotFound.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 157da8cb44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Put Block rejects an id whose length differs from a blob's leftover uncommitted blocks, so a write after an interrupted 0.21 multipart upload of the same blob, such as a file-backed metastore.json, failed until those blocks expired.
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The SDK wraps failures such as DNS or Entra ID errors in a generic "non-transport error occurred which will not be retried", and only that message reached the storage error.
dayaffe
added
area:storage
Description
Migrates the Azure Blob Storage backend from the legacy 0.21 Azure SDK to the 1.0 SDK. Based on #6693 by @siva-abstract-security.
Fixes #6672: indexers using AKS workload identity lost storage access 24 hours after startup.
azure_identity1.0 re-reads the token file, so tokens keep refreshing.The 1.0 SDK dropped shared key auth and
create_credential(), so both are rebuilt here. Uploads now carry a CRC64 checksum that Azure verifies, and each download is a single streamed request.Behavior changes:
AZURE_CREDENTIAL_KIND=azurecli, not as a fallback.AZURE_CLIENT_IDalone selects a user-assigned managed identity.AZURE_CREDENTIAL_KINDis an error, and token credentials need anhttpsendpoint.AZURE_FEDERATED_TOKENis replaced byAZURE_FEDERATED_TOKEN_FILE.How was this PR tested?
quickwit-storageunit tests, workspace clippy, and the Azurite suite, plus a new test that retries a commit that already succeeded.get_all,copy_to, ranged and streamed reads, and deletes. Reads also checked with token auth via the Azure CLI.